Discussion:
[asterisk-dev] ContactStatus AMI Event on PJSIP Reregistration
Joshua Colp
2018-08-15 14:00:48 UTC
Permalink
Kia ora,

I currently have a code review up[1] which removes the ContactStatus AMI event when a PJSIP endpoint re-registers. I removed it as I believed the ContactStatus event was redundant (as the status has not changed from the last event that would have been sent). Does anyone currently rely on this behavior?

Cheers,

[1] https://gerrit.asterisk.org/#/c/asterisk/+/9822/
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium.com/mailman/listinfo/aster
Leandro Dardini
2018-08-15 14:54:02 UTC
Permalink
While you work on the AMI events for PJSIP endpoints, don't forget the
issue with no AMI events issued when a PJSIP endpoint loses completely the
connectivity. If it de-registers, an event is fired, if you just pull the
plug, no events are generated.

Leandro
Post by Joshua Colp
Kia ora,
I currently have a code review up[1] which removes the ContactStatus AMI
event when a PJSIP endpoint re-registers. I removed it as I believed the
ContactStatus event was redundant (as the status has not changed from the
last event that would have been sent). Does anyone currently rely on this
behavior?
Cheers,
[1] https://gerrit.asterisk.org/#/c/asterisk/+/9822/
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --
asterisk-dev mailing list
http://lists.digium.com/mailman/listinfo/asterisk-dev
Joshua Colp
2018-08-15 14:58:21 UTC
Permalink
Post by Leandro Dardini
While you work on the AMI events for PJSIP endpoints, don't forget the
issue with no AMI events issued when a PJSIP endpoint loses completely the
connectivity. If it de-registers, an event is fired, if you just pull the
plug, no events are generated.
If properly configured (qualify is enabled) then an event will be generated that it has become unreachable[1]. Without qualify there is no way for Asterisk to know this.

[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+13+ManagerEvent_ContactStatus
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digium
Olivier
2018-08-16 07:37:39 UTC
Permalink
Message: 3
Date: Wed, 15 Aug 2018 11:58:21 -0300
Subject: Re: [asterisk-dev] ContactStatus AMI Event on PJSIP
Reregistration
Content-Type: text/plain; charset="utf-8"
Post by Leandro Dardini
While you work on the AMI events for PJSIP endpoints, don't forget the
issue with no AMI events issued when a PJSIP endpoint loses completely
the
Post by Leandro Dardini
connectivity. If it de-registers, an event is fired, if you just pull the
plug, no events are generated.
If properly configured (qualify is enabled) then an event will be
generated that it has become unreachable[1]. Without qualify there is no
way for Asterisk to know this.
[1] https://wiki.asterisk.org/wiki/display/AST/Asterisk+13+
ManagerEvent_ContactStatus
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org
Hello Joshua,

I can think of a RegistrationExpiredWithoutRenewal event that is quite
independant of Qualify settings and still can be useful.
Joshua Colp
2018-08-16 09:16:18 UTC
Permalink
On Thu, Aug 16, 2018, at 4:37 AM, Olivier wrote:

<snip>
Post by Olivier
Hello Joshua,
I can think of a RegistrationExpiredWithoutRenewal event that is quite
independant of Qualify settings and still can be useful.
I believe this should already occur.

My original question wasn't about refining ContactStatus or changing it substantially directly, the fact that I'm asking my original question is just because I'd like to remove that code which consumes extra resources for something which I personally think is redundant.
--
Joshua Colp
Digium, Inc. | Senior Software Developer
445 Jan Davis Drive NW - Huntsville, AL 35806 - US
Check us out at: www.digium.com & www.asterisk.org
--
_____________________________________________________________________
-- Bandwidth and Colocation Provided by http://www.api-digital.com --

asterisk-dev mailing list
To UNSUBSCRIBE or update options visit:
http://lists.digiu
Loading...